On Mon, 18 Jan 2016, Javen O'Neal wrote:
There are certainly some good cases for having Util classes, but sometimes the best thing is to have the functionality right in the class. The problem is there is no place to put code that would be used by all implementing classes besides a utility.
Minor naming thing - on the whole, we use *Util classes for things that end users will call, and *Helper for things that POI will internally call. Isn't always consistent, but that's generally the plan!
Perhaps we should convert Workbook, Sheet, Row, and Cell (and really everything) to abstract classes so that generic code can be written in one place rather than duplicated across implementing classes.
That'd sadly break backwards compatibility for almost all of our users, even if only at the binary level.
In the past, there has been talk of other formats (eg ODF) implementing our interfaces to get consistent handling for their spreadsheets too. I haven't heard of any public implementations of that, but there may be private ones that we'd risk breaking
Also, is there that much that's common for (eg) HSSFCell & XSSFCell & SXSSFCell & that proposed hybrid sax reading thingy? (Genuine question!)
Nick --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
