https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
--- Comment #18 from Mark Murphy <[email protected]> --- (In reply to Javen O'Neal from comment #17) > If you want to check that your code compiles (and passes unit tests) before > generating the patch file, run "ant test" or "ant clean test". "ant test" unit tests fail before it gets to my test, so I am just running my tests manually. > Anything in > org.apache.poi.ss.util should probably work on all 3 kinds of workbooks, > with the same behavior (unless a different behavior makes sense) Not real sure how this would make sense with this utility. I don't know enough about how SXSSF works to make this work for that type of spreadsheet. It requires the sheet to be in memory all at once, or at least the portion that the template is being applied against. > You mentioned in the javadocs that PropertyTemplate would replace > RegionUtil. I haven't compared the two classes side-by-side yet. Do you mean > that PropertyTemplate is a higher-level wrapper around RegionUtil, and that > most people using RegionUtil would likely be more interested in > PropertyTemplate? Or is PropertyTemplate a rewrite of RegionUtil, fixing > inconsistencies in the provided methods? My thought is that RegionUtil would be deprecated in favor of PropertyTemplate. PropertyTemplate is most accurately a rewrite of RegionUtil with an eye toward reducing the number of CellStyles created while borders are being written. It is possible that RegionUtil could be adjusted to use the PropertyTemplate class, but that would still create excess styles as each border is added to the CellStyle one at a time in RegionUtil. I would favor dropping it since it does nothing else, and renaming PropertyTemplate to RegionUtil makes little sense since RegionUtil is a "static only" class, but PropertyTemplate is not. The two classes work differently. The one advantage RegionUtil has over PropertyTemplate is that it can be used with SXSSF since it can be used with a limited set of rows. Now that I am thinking of it more, maybe PropertyTemplate can indeed be used with SXSSFWorkbooks by adding an option to apply the template to just the rows in memory, and ignoring template rows that are not in memory. Or by adding a feature to allow applying a smaller template to a relative position in the sheet. As far as the unavailable classes in the links, and test, I will look at some other tests, and rewrite mine to conform. I did not notice the inability to compile, probably because I don't have something configured correctly in eclipse. I will figure that out. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
