On Thu, 31 Mar 2016, Murphy, Mark wrote:
If you have any questions or comments, I would love to hear your
feedback.
I haven't looked at this patch of yours. However...
Several small patches are easier to review and apply than one big, for
un-related fixes or improvements. However, one big patch is often easier
to review for a big change. Patches with unit tests are safer than those
without
Using a git fork can help with some of these things. It's possible to work
on a bunch of stuff at once, committing locally, then edit (squashing +
cherry-picking) into a logical set of changes to review. However, you can
also shoot your own feet off easier with git, so do beware ;-)
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
