https://bz.apache.org/bugzilla/show_bug.cgi?id=57840

--- Comment #36 from Andreas Beeker <[email protected]> ---
TL;DR: please comment non obvious performance hacks


As I usually delete all *ssf bug notifications, I wasn't aware of those
autoboxing changes and after findbugs complaint about them, I changed them back
to the state before the changes (i.e. as there were quite a lot of svn changes
and I haven't checked the history, when going through the findbugs issues)

After I've committed the autoboxing, I thought there might be something wrong,
otherwise such simple issues would have been already removed.
So now the code for XSSFRow is reverted again and I've added the necessary
ignore rules to the findbugs-filters, but for future modifications, it would be
good if you add a comment, when doing something on purpose against usual
optimizations, otherwise the next patch might throw out those lines again ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to