https://bz.apache.org/bugzilla/show_bug.cgi?id=58787
--- Comment #39 from Javen O'Neal <[email protected]> --- When there is no significant speed or memory benefit to using (int row, int col) arguments over a more descriptive CellAddress argument to a public function, only the function using the CellAddress argument should be in the public API. This keeps classes smaller and easier to find the function that needs to be used, even if it moves the CellAddress object creation from the POI library to user code. This is probably a good thing because it encourages reuse of the CellAddress objects (hiding the object creation in the method hides that cost). I would recommend deleting the following methods: > public int getNumBorders(int row, int col) > public BorderStyle getBorderStyle(int row, int col, String property) > public int getNumBorderColors(int row, int col) > public short getTemplateProperty(int row, int col, String property) Every POI entry point is: * another function to test * another potential bug (null pointer and range check being the most likely) * mental burden for the user to figure out which variant of a function to use. These can be completely removed (no deprecation warning) without a deprecation warning up to 3.15 final release. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
