https://bz.apache.org/bugzilla/show_bug.cgi?id=59853
--- Comment #10 from Javen O'Neal <one...@apache.org> --- (In reply to Greg Woolsey from comment #9) > It would have to be 3 functions, like the createPivotTable methods in > XSSFSheet, with duplicated code. The XML overloads the same "name" > attribute to reference an XSSFName and an XSSFTable. We could do the 3 > object variants, and a functional interface to configure the > CTWorksheetSource as needed, passing inline anonymous classes to do that bit > of the logic. What subclasses XSSFPivotTable that would require this method to be overridden or use anonymous classes? I haven't looked that closely at the code yet. Leave it alone for now if you can't find a more complicated solution. As you said, it doesn't matter as much being a protected method. > > Also, could you upgrade the unit tests to junit3 instead of junit4 I mis-typed. We would like to upgrade from junit3 (junit.*, "extends TestCase") to junit4 (org.junit.*, "@Test"). On second thought, I'll take care of the upgrade myself. It'll keep your diff smaller and easier to review. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
