https://bz.apache.org/bugzilla/show_bug.cgi?id=60219

Javen O'Neal <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34334|0                           |1
        is obsolete|                            |

--- Comment #1 from Javen O'Neal <[email protected]> ---
Created attachment 34342
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34342&action=edit
FormulaParser.java and unit test patch for quoted external sheet names

Thanks for the patch! I added a unit test (attached) to make sure this stays
fixed in the future.

Unfortunately, this patch cannot be committed yet because it breaks
o.a.p.hssf.usermodel.TestBugs#bug45970.

row.getCell(1).setCellFormula("'[$http://gagravarr.org/FormulaRefs2.xls]Sheet1'!B2");

> No external workbook with name '$http://gagravarr.org/FormulaRefs2.xls'
> java.lang.RuntimeException: No external workbook with name 
> '$http://gagravarr.org/FormulaRefs2.xls'
>         at 
> org.apache.poi.hssf.model.LinkTable.getExternalSheetIndex(LinkTable.java:445)
>         at 
> org.apache.poi.hssf.model.InternalWorkbook.getExternalSheetIndex(InternalWorkbook.java:2012)
>         at 
> org.apache.poi.hssf.usermodel.HSSFEvaluationWorkbook.getSheetExtIx(HSSFEvaluationWorkbook.java:300)
>         at 
> org.apache.poi.hssf.usermodel.HSSFEvaluationWorkbook.get3DReferencePtg(HSSFEvaluationWorkbook.java:94)
>         at 
> org.apache.poi.ss.formula.FormulaParser.createAreaRefParseNode(FormulaParser.java:957)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parseRangeable(FormulaParser.java:568)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parseRangeExpression(FormulaParser.java:311)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parseSimpleFactor(FormulaParser.java:1517)
>         ...
>         at 
> org.apache.poi.ss.formula.FormulaParser.unionExpression(FormulaParser.java:1857)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parse(FormulaParser.java:2005)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parse(FormulaParser.java:170)
>         at 
> org.apache.poi.ss.formula.FormulaParser.parse(FormulaParser.java:190)
>         at 
> org.apache.poi.hssf.model.HSSFFormulaParser.parse(HSSFFormulaParser.java:108)
>         at 
> org.apache.poi.hssf.usermodel.HSSFCell.setCellFormula(HSSFCell.java:622)
>         at org.apache.poi.hssf.usermodel.TestBugs.bug45970(TestBugs.java:1852)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to