https://bz.apache.org/bugzilla/show_bug.cgi?id=60737
Javen O'Neal <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #6 from Javen O'Neal <[email protected]> --- (In reply to zakim from comment #4) > Created attachment 34759 [details] > patched XSSFEventBasedExcelExtractor > > The missing file patched. Please submit patches generated by "svn diff", "git-svn diff" or "ant -f patch.xml" [1] Entire files are difficult to review and commit because other changes may be made to that file after you attached it. Additionally, I am unclear how this contribution will help POI. Adding a method that does nothing may be a source of confusion for people reading or maintaining the code. If your intent is to have POI define a method that you plan on overriding in your own code, how do you plan on using that? Could someone else override this inner class without modifying POI source code? If so, perhaps this change is worthy of example code or documentation so that others know how to override endSheet(). [1] https://poi.apache.org/guidelines.html#Submitting+Patches -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
