https://bz.apache.org/bugzilla/show_bug.cgi?id=60891

            Bug ID: 60891
           Summary: LittleEndianInputStream's readFully() doesn't
           Product: POI
           Version: 3.16-dev
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POIFS
          Assignee: [email protected]
          Reporter: [email protected]
  Target Milestone: ---

While trying to write an example of TestSecureTempZip's protectedTempZip for
the new XLSB parser, I got an exception which I tracked down to
LittleEndianInputStream's readFully, doesn't actually read fully; rather, it
makes a single call to read and then checks if that hit EOF.  

When I fixed it (i.e. copied/pasted from commons-io IOUtils readFully) to read
until the length was hit or an EOF was hit, the example worked with an
encrypted xlsb.  All unit (including stress) tests pass.

Any objections to fixing this?  

Or, does this subtly change the expectations of readFully, and I should leave
this as is?

This seems like such a core component, we should have found this earlier?!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to