See <https://builds.apache.org/job/POI-DSL-1.6/352/display/redirect?page=changes>
Changes: [gwoolsey] Bug 61203 - XSSFDrawing.getAnchorFromParent handles CTOneCellAnchor incorrectly, ignores CTAbsoluteAnchor This is likely incomplete, but closer to where things should be. It is backward compatible with previous uses of XSSFClientAnchor. This fixes a bug in XSSFGraphicFrame that was hiding the parent class anchor property (which is a protected field set directly from XSSFDrawing). This is a peril of using direct property access - the hiding wasn't obvious because there was no setter being overridden. XSSFGraphicFrame now notices when it relates to a chart, and setts the frame property of the XSSFChart. That was not being set on parse previously, only when creating charts from scratch. That didn't seem right. XSSFClientAnchor now calculates size and position correctly based on initial inputs from the different types of anchors. It DOES NOT update those initial inputs, however. It does properly adjust if the size or initial position are absolute and the corresponding row/column values are requested. Added new class EMUUtils to centralize the measurement constants and conversions since there are so many units in play in the OOXML spec and POI APIs: * EMUs (English Metric Units) * Inches * Centimeters * Points * Pixels * Twips (1/20th of a point) I'm sure there are more conversions that could be done there, I just started with what I needed. ------------------------------------------ [...truncated 435.03 KB...] [javadoc] Loading source files for package org.apache.poi.hsmf.datatypes... [javadoc] Loading source files for package org.apache.poi.hsmf.dev... [javadoc] Loading source files for package org.apache.poi.hsmf.exceptions... [javadoc] Loading source files for package org.apache.poi.hsmf.extractor... [javadoc] Loading source files for package org.apache.poi.hsmf.parsers... [javadoc] Loading source files for package org.apache.poi.hssf.converter... [javadoc] Loading source files for package org.apache.poi.hwmf.draw... [javadoc] Loading source files for package org.apache.poi.hwmf.record... [javadoc] Loading source files for package org.apache.poi.hwmf.usermodel... [javadoc] Loading source files for package org.apache.poi.hwpf... [javadoc] Loading source files for package org.apache.poi.hwpf.converter... [javadoc] Loading source files for package org.apache.poi.hwpf.dev... [javadoc] Loading source files for package org.apache.poi.hwpf.extractor... [javadoc] Loading source files for package org.apache.poi.hwpf.model... [javadoc] Loading source files for package org.apache.poi.hwpf.model.io... [javadoc] Loading source files for package org.apache.poi.hwpf.model.types... [javadoc] Loading source files for package org.apache.poi.hwpf.sprm... [javadoc] Loading source files for package org.apache.poi.hwpf.usermodel... [javadoc] Loading source files for package org.apache.poi.openxml4j.exceptions... [javadoc] Loading source files for package org.apache.poi.openxml4j.opc... [javadoc] Loading source files for package org.apache.poi.openxml4j.opc.internal... [javadoc] Loading source files for package org.apache.poi.openxml4j.opc.internal.marshallers... [javadoc] Loading source files for package org.apache.poi.openxml4j.opc.internal.unmarshallers... [javadoc] Loading source files for package org.apache.poi.openxml4j.util... [javadoc] Loading source files for package org.apache.poi.poifs.crypt.agile... [javadoc] Loading source files for package org.apache.poi.poifs.crypt.dsig... [javadoc] Loading source files for package org.apache.poi.poifs.crypt.dsig.facets... [javadoc] Loading source files for package org.apache.poi.poifs.crypt.dsig.services... [javadoc] Loading source files for package org.apache.poi.poifs.crypt.temp... [javadoc] Loading source files for package org.apache.poi.xdgf.exceptions... [javadoc] Loading source files for package org.apache.poi.xdgf.extractor... [javadoc] Loading source files for package org.apache.poi.xdgf.geom... [javadoc] Loading source files for package org.apache.poi.xdgf.usermodel... [javadoc] Loading source files for package org.apache.poi.xdgf.usermodel.section... [javadoc] Loading source files for package org.apache.poi.xdgf.usermodel.section.geometry... [javadoc] Loading source files for package org.apache.poi.xdgf.usermodel.shape... [javadoc] Loading source files for package org.apache.poi.xdgf.usermodel.shape.exceptions... [javadoc] Loading source files for package org.apache.poi.xdgf.util... [javadoc] Loading source files for package org.apache.poi.xdgf.xml... [javadoc] Loading source files for package org.apache.poi.xslf.extractor... [javadoc] Loading source files for package org.apache.poi.xslf.model... [javadoc] Loading source files for package org.apache.poi.xslf.usermodel... [javadoc] Loading source files for package org.apache.poi.xslf.util... [javadoc] Loading source files for package org.apache.poi.xssf... [javadoc] Loading source files for package org.apache.poi.xssf.binary... [javadoc] Loading source files for package org.apache.poi.xssf.dev... [javadoc] Loading source files for package org.apache.poi.xssf.eventusermodel... [javadoc] Loading source files for package org.apache.poi.xssf.extractor... [javadoc] Loading source files for package org.apache.poi.xssf.model... [javadoc] Loading source files for package org.apache.poi.xssf.streaming... [javadoc] Loading source files for package org.apache.poi.xssf.usermodel... [javadoc] Loading source files for package org.apache.poi.xssf.usermodel.charts... [javadoc] Loading source files for package org.apache.poi.xssf.usermodel.extensions... [javadoc] Loading source files for package org.apache.poi.xssf.usermodel.helpers... [javadoc] Loading source files for package org.apache.poi.xssf.util... [javadoc] Loading source files for package org.apache.poi.xwpf.extractor... [javadoc] Loading source files for package org.apache.poi.xwpf.model... [javadoc] Loading source files for package org.apache.poi.xwpf.usermodel... [javadoc] Constructing Javadoc information... [javadoc] Standard Doclet version 1.6.0_45 [javadoc] Building tree for all the packages and classes... [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:39: warning - Tag @link: reference not found: AnchorType [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:80: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:98: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:118: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:132: warning - Tag @link: reference not found: AnchorType#MOVE_DONT_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:148: warning - Tag @link: reference not found: AnchorType#DONT_MOVE_AND_RESIZE [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/site/build/site/apidocs/stylesheet.css...> [javadoc] 6 warnings [javadoc] Patched 1 link injection vulnerable javadocs jar-src: [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi/poi-3.17-beta1-sources.jar> [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-scratchpad/poi-scratchpad-3.17-beta1-sources.jar> [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-ooxml/poi-ooxml-3.17-beta1-sources.jar> [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-examples/poi-examples-3.17-beta1-sources.jar> [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-excelant/poi-excelant-3.17-beta1-sources.jar> -do-jar-check-javadocs-package-list: -do-jar-create-javadocs-package-list: jar-javadocs: [echo] Building poi javadocs from <https://builds.apache.org/job/POI-DSL-1.6/ws/src/java> [mkdir] Created dir: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs> [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Patched 1 link injection vulnerable javadocs [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi/poi-3.17-beta1-javadoc.jar> [echo] Building poi-scratchpad javadocs from <https://builds.apache.org/job/POI-DSL-1.6/ws/src/scratchpad/src> [delete] Deleting directory <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs> [mkdir] Created dir: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs> [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] Patched 1 link injection vulnerable javadocs [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-scratchpad/poi-scratchpad-3.17-beta1-javadoc.jar> [echo] Building poi-ooxml javadocs from <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java> [delete] Deleting directory <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs> [mkdir] Created dir: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/tmp/maven-javadocs> [javadoc] Generating Javadoc [javadoc] Javadoc execution [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:39: warning - Tag @link: reference not found: AnchorType [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:80: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:98: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:118: warning - Tag @link: reference not found: AnchorType#MOVE_AND_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:132: warning - Tag @link: reference not found: AnchorType#MOVE_DONT_RESIZE [javadoc] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFClientAnchor.java>:148: warning - Tag @link: reference not found: AnchorType#DONT_MOVE_AND_RESIZE [javadoc] 6 warnings [javadoc] Patched 1 link injection vulnerable javadocs [jar] Building jar: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven/poi-ooxml/poi-ooxml-3.17-beta1-javadoc.jar> assemble: [zip] Building zip: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/poi-bin-3.17-beta1-20170623.zip> [tar] Building tar: <https://builds.apache.org/job/POI-DSL-1.6/352/artifact/build/dist/poi-bin-3.17-beta1-20170623.tar.gz> [zip] Building zip: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/poi-src-3.17-beta1-20170623.zip> [tar] Building tar: <https://builds.apache.org/job/POI-DSL-1.6/352/artifact/build/dist/poi-src-3.17-beta1-20170623.tar.gz> [echo] Creating Maven POMs maven-poms: [copy] Copying 6 files to <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist/maven> [echo] Maven POMs are located in <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist> [echo] Use ant dist-nexus to deploy the artifacts in the remote repository [echo] Distribution located in <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist> [echo] Use "ant dist-checksum" to create md5/sha1 checksums and GPG signatures findbugs: [get] Destination already exists (skipping): <https://builds.apache.org/job/POI-DSL-1.6/ws/lib/findbugs-noUpdateChecks-2.0.3.zip> [unzip] Expanding: <https://builds.apache.org/job/POI-DSL-1.6/ws/lib/findbugs-noUpdateChecks-2.0.3.zip> into <https://builds.apache.org/job/POI-DSL-1.6/ws/build/findbugs> [findbugs] Executing findbugs FindBugsTask from ant task [findbugs] Running FindBugs... [findbugs] Warnings generated: 38 [findbugs] Calculating exit code... [findbugs] Setting 'bugs found' flag (1) [findbugs] Exit code set to: 1 [findbugs] Java Result: 1 [findbugs] Output saved to build/findbugs.xml [xslt] Transforming into <https://builds.apache.org/job/POI-DSL-1.6/ws/build> [xslt] Processing <https://builds.apache.org/job/POI-DSL-1.6/ws/build/findbugs.xml> to <https://builds.apache.org/job/POI-DSL-1.6/352/artifact/build/findbugs.html> [xslt] Loading stylesheet jar:<https://builds.apache.org/job/POI-DSL-1.6/ws/build/findbugs/lib/findbugs.jar!/fancy-hist.xsl> release-notes: [copy] Copying 1 file to <https://builds.apache.org/job/POI-DSL-1.6/ws/build/dist> rat-check: [mkdir] Created dir: <https://builds.apache.org/job/POI-DSL-1.6/ws/build/rat> [echo] [echo] ***************************************************** [echo] Summary [echo] ------- [echo] Generated at: 2017-06-23T06:05:39+00:00 [echo] [echo] Notes: 1 [echo] Binaries: 119 [echo] Archives: 0 [echo] Standards: 3595 [echo] [echo] Apache Licensed: 3594 [echo] Generated Documents: 0 [echo] [echo] JavaDocs are generated, thus a license header is optional. [echo] Generated files do not require license headers. [echo] [echo] 1 Unknown Licenses [echo] [echo] ***************************************************** [echo] [echo] Files with unapproved licenses: [echo] [echo] <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/util/EMUUtils.java> [echo] [echo] ***************************************************** [echo] [echo] ***************************************************** [echo] Files with Apache License headers will be marked AL [echo] Binary files (which do not require any license headers) will be marked B [echo] Compressed archives will be marked A [echo] Notices, licenses etc. will be marked N [echo] !????? <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/util/EMUUtils.java> [echo] [echo] ***************************************************** [echo] [echo] Printing headers for text files without a valid license header... [echo] [echo] ===================================================== [echo] == File: <https://builds.apache.org/job/POI-DSL-1.6/ws/src/ooxml/java/org/apache/poi/xssf/util/EMUUtils.java> [echo] ===================================================== [echo] package org.apache.poi.xssf.util; [echo] [echo] import org.apache.poi.xssf.usermodel.XSSFShape; [echo] import org.apache.poi.xssf.usermodel.XSSFWorkbook; [echo] [echo] /** [echo] * Conversion methods for OOXML EMU values - "English Metric Units" or more accurately [echo] * "Evil Measurement Units". [echo] * <p/> [echo] * These are defined briefly in <a href="https://en.wikipedia.org/wiki/Office_Open_XML_file_formats#DrawingML";>Wikipedia</a> [echo] * as a "rational" way to use an integer value to represent something that could be in [echo] * inches, centimeters, points, or pixels. [echo] * So now we get to convert between all those. [echo] */ [echo] public class EMUUtils { [echo] public static final int EMUS_PER_INCH = 914400; [echo] public static final int EMUS_PER_POINT = 12700; [echo] public static final int EMUS_PER_CENTIMETER = 360000; [echo] [echo] // TODO: these could move here or something to standardize definitions [echo] public static final int EMU_PER_PIXEL = XSSFShape.EMU_PER_PIXEL; [echo] public static final int EMU_PER_POINT = XSSFShape.EMU_PER_POINT; [echo] public static final int PIXEL_DPI = XSSFShape.PIXEL_DPI; [echo] public static final int POINT_DPI = XSSFShape.POINT_DPI; [echo] public static final int EMU_PER_CHARACTER = (int) (EMU_PER_PIXEL * XSSFWorkbook.DEFAULT_CHARACTER_WIDTH); [echo] [echo] /** [echo] * @param columnWidth as (fractional # of characters) * 256 [echo] * @return EMUs [echo] */ [echo] public static final int EMUsFromColumnWidth(int columnWidth) { [echo] return (int) (columnWidth /256d * EMUUtils.EMU_PER_CHARACTER); [echo] } [echo] [echo] /** [echo] * @param twips (1/20th of a point) typically a row height [echo] * @return EMUs [echo] */ [echo] public static final int EMUsFromTwips(short twips) { [echo] return (int) (twips / 20d * EMU_PER_POINT); [echo] } [echo] [echo] /** [echo] * @param points (fractional) [echo] * @return EMUs [echo] */ [echo] public static final int EMUsFromPoints(float points) { [echo] return (int) (points * EMU_PER_POINT); [echo] } [echo] } BUILD FAILED <https://builds.apache.org/job/POI-DSL-1.6/ws/build.xml>:2211: condition satisfied Total time: 41 minutes 59 seconds Build step 'Invoke Ant' marked build as failure Skipping publisher since build result is FAILURE Archiving artifacts Compressed 226.59 MB of artifacts by 43.7% relative to #351 Skipping publisher since build result is FAILURE Recording test results --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
