I thought that the writeAttribute made the code a bit easier to read. Also, concatenating strings before writing them to the Writer does add overhead. I did some similar work (with others) on a similar writer implementation in February and removing the string concats and using additional write calls instead did lead to better performance.
These changes were in: https://github.com/prometheus/client_java/commits/master/simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.java The performance test: https://github.com/pkubowicz/prometheus-client-test I'm not wedded to the r1801806 change, so if there are objections, I can revert it. -- View this message in context: http://apache-poi.1045710.n5.nabble.com/Re-svn-commit-r1801806-in-poi-trunk-src-ooxml-java-org-apache-poi-xssf-streaming-SXSSFWorkbook-java-a-tp5728214p5728215.html Sent from the POI - Dev mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
