https://bz.apache.org/bugzilla/show_bug.cgi?id=61337
--- Comment #4 from Tim Allison <[email protected]> --- I'll probably start on this one class/family at a time unless there are objections. It looks like there are basically 4 places where we rely on assert. 1) assert that things are or aren't null, as in DrawTextParagraph: String buFontStr = bulletStyle.getBulletFont(); if (buFontStr == null) { buFontStr = paragraph.getDefaultFontFamily(); } assert(buFontStr != null); FontInfo buFont = new DrawFontInfo(buFontStr); 2) assert instanceof, as in Range: assert ( _doc instanceof HWPFDocument ); 3) assert x == y to confirm that a record is not wonky, as in HwmfBitmapDib: assert(introSize == headerSize); or in LittleEndianByteArrayInputStream: assert skipped == size : "Buffer overrun"; 4) checks on limitations of implementation as in: assert false : "hashCode not designed"; There may be other uses as well... Proposed solutions: 1) RecordFormatException? Or something else? 2) What exception should we use here? 3) is straightforward, I think: RecordFormatException 4) is straightforward, I think: implement/auto-generate a hashcode -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
