https://bz.apache.org/bugzilla/show_bug.cgi?id=61745
--- Comment #8 from Javen O'Neal <[email protected]> --- Thank you for adding support for charts in XWPF! Would you be able to write some unit tests (or modify existing ones) to cover the new and changed functionality? See https://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFPictureData.java?view=log for an example. Would you also be able to make the following changes: XWPFDocument#getCharts: return Collections.unmodifiableList(charts); XWPFChart: Remove @Deprecated API's in XWPFChart. No need for deprecated API's in new code. Update javadocs to @since POI 4.0.0 It looks like this was modeled after XWPFPictureData. To whoever ends up committing this code to the svn repo, an "svn cp XWPFPictureData.java XWPFChart.java; cp patch.tar.gz/XWPFChart.java ." might make sense. If there's any code that XWPFChart and XWPFPictureData share in common, it may make sense to create a class that implements the common methods. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
