https://bz.apache.org/bugzilla/show_bug.cgi?id=62355

--- Comment #10 from Andreas Beeker <kiwiwi...@apache.org> ---
Maybe I should I explain a bit shorter, to make my self clear:

- for POI 4.0.0 I want to change the java-package of around 10 classes and
leave
  the maven-packaging as is. This is sufficient to make module-info work in
user code ...
  at least I didn't get any compile/execution errors

- for POI 5 *), I want a repackaging by document type

- for POI 6 *), I want to upgrade to real modules / Java 9
  and we also need to fix XmlBeans then

*) just a rough plan, but in that order


> If I understand things correctly, the module-info piece works as a
> dependency manager for jigsaw modules. But if we go all in on that,
> would it interfere with Java 8 compatibility?

I guess so -> https://github.com/google/guava/issues/2970



> I suggest that we should not make the move to modules yet because none of
> our dependencies have made the switch. ...

Regarding the modules, I'd go in the steps above


> And we should only move POI to modules when all of our dependencies are 
> modularized ...

ACK, but we might ask them about their Jigsaw plans and about adding the
Automatic-Module-Name manifest entry




> I do believe that modules are the way to go, but we must be intentional about
> it if we are to avoid unintended consequences.

If we go in two steps, we don't have two building sites at once ...
For the time being, I don't think that adding an Automatic-Module-Name entry
would make sense for us.



> ... and any questions are met with "you are on a very old version of jqGrid,
> try upgrading first".

ha ha ... I like that twist, i.e. the implicit comparision to our typical SO
answers.
Looking at our dependencies, I don't think commons-codec/collection would
upgrade before us, but currently I don't think that's a problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to