GitHub user mayuranchalia opened a pull request:
https://github.com/apache/poi/pull/112
Support for LineStyle in XSSFComment
XSSFComment doesn't have support for Linestyle similar to HSSFComment
In HSSFComment we have functions like setLineStyle and setLineStyleColor,
similar feature is required for XSSFComment .
Bugzilla bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=62247
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/poi trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/poi/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit fb321255e8aab6f51ef579c554ff1b5028e3a2d3
Author: Javen O'Neal <onealj@...>
Date: 2017-11-07T00:29:09Z
bug 61730: add iterator interface to CellRangeAddressBase for iterating
over CellAddresses
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814448
13f79535-47bb-0310-9956-ffa450edef68
commit 841cc75ee498921c97fd9386e8f564e75010f173
Author: Javen O'Neal <onealj@...>
Date: 2017-11-07T01:54:25Z
bug 61730: add javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814451
13f79535-47bb-0310-9956-ffa450edef68
commit 163673a7aa8b42324f4aa922971a9475ddcdee62
Author: Javen O'Neal <onealj@...>
Date: 2017-11-07T07:21:24Z
bug 61730: remove CellRangeAddressBase which is eager. The lazy iterator is
safer, less likely to cause an OOM/DoS.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814461
13f79535-47bb-0310-9956-ffa450edef68
commit 8b0145c6e0cb27ac72610271073ebac140e5ca5a
Author: Javen O'Neal <onealj@...>
Date: 2017-11-07T07:26:48Z
bug 61730: remove asSet function from unit test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814462
13f79535-47bb-0310-9956-ffa450edef68
commit 2d5b6457c6d5dd5a8f910d726bb493233b01724b
Author: Dominik Stadler <centic@...>
Date: 2017-11-08T14:59:08Z
Some JavaDoc adjustments, typos, IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587
13f79535-47bb-0310-9956-ffa450edef68
commit 70fdcdf8481cdcf3c6465a189956e30822a3e96f
Author: Mark Murphy <jmarkmurphy@...>
Date: 2017-11-11T14:18:24Z
Surface XSSF Header/Footer Attributes (60887)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814950
13f79535-47bb-0310-9956-ffa450edef68
commit c1e6c2eef7949e74e99d6dda799d2be1b9c6b6ff
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T01:30:42Z
deprecate XWPFTable#addNewRowBetween(int,int), which has not been
implemented since 2008 when this class was first authored. (Unrelated: This
closes #82 on github).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814997
13f79535-47bb-0310-9956-ffa450edef68
commit fd29e874025e5d2ab6f6595ccc9687639124dc2f
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T01:32:43Z
make tableRows final; initialize where defined rather than in constructor.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814998
13f79535-47bb-0310-9956-ffa450edef68
commit 1bc1bdb58b2b3517c98ebc5899810f8ce1234411
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T01:34:52Z
XWPFTable#getRows() should return an unmodifiable list unless the method
can correctly update xmlbeans in response to modifying the list
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814999
13f79535-47bb-0310-9956-ffa450edef68
commit fbccf3066cda10b8f1408d11785a1d07a24a8f18
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T06:14:43Z
github #81: sheet names are case insensitive
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815001
13f79535-47bb-0310-9956-ffa450edef68
commit bac484ba379cc226ace386fdd851ffd8bdc76b12
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T06:52:38Z
+svn:eol-style native *.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815002
13f79535-47bb-0310-9956-ffa450edef68
commit a1b8f3ff1446f1e52d9ced9de8370e10cf5e5faa
Author: Javen O'Neal <onealj@...>
Date: 2017-11-12T21:48:41Z
bug 61745: add support for charts in XWPF/docx. Thanks to Sandeep Tiwari
for the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815047
13f79535-47bb-0310-9956-ffa450edef68
commit f062e7f1c2c278b19f5fb7ac86bb7df9d3a48882
Author: Javen O'Neal <onealj@...>
Date: 2017-11-13T00:51:41Z
bug 61745: remove String#toString() usage found by forbidden apis check
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815048
13f79535-47bb-0310-9956-ffa450edef68
commit 1b9d599882ba628b8d7499b807e404186ffa1ac0
Author: Dominik Stadler <centic@...>
Date: 2017-11-13T11:44:50Z
Fix tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815085
13f79535-47bb-0310-9956-ffa450edef68
commit 3e70d22cbc45f1460583127e9c430a461b7852c9
Author: Dominik Stadler <centic@...>
Date: 2017-11-13T11:46:04Z
Fix setting a font-color if no previous color is defined for the font
Add unit-test to verify this
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815086
13f79535-47bb-0310-9956-ffa450edef68
commit ff034f6a20fc489f5b5b582315ae58b7405075f9
Author: Greg Woolsey <gwoolsey@...>
Date: 2017-11-15T08:35:17Z
Fixes Bug 61764 Conditional formatting rules don't evaluate properly for
some multi-range rule definitions
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like
comparing cells of different types
fixed, with unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298
13f79535-47bb-0310-9956-ffa450edef68
commit 963a8fedae826168503a7b0002d64d0fc2cad5a7
Author: Greg Woolsey <gwoolsey@...>
Date: 2017-11-15T16:34:14Z
ignore a unit test that snuck in. It was created to investigate an open
bug report. It fails, as expected, which broke the build.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336
13f79535-47bb-0310-9956-ffa450edef68
commit 9d11d1c3ea40ee606f225093818efdf067b3be91
Author: Greg Woolsey <gwoolsey@...>
Date: 2017-11-16T01:22:52Z
add Locale awareness to case insensitive conditional comparisons in
formatting rule logic. Needed anyway, and removes forbidden API issues.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815404
13f79535-47bb-0310-9956-ffa450edef68
commit c37a85d97479e4fed8bc0de06668fdae6296b44a
Author: Mark Murphy <jmarkmurphy@...>
Date: 2017-11-19T01:35:07Z
javadocs and Quick page improvements for XSSF Header/Footer
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815706
13f79535-47bb-0310-9956-ffa450edef68
commit 9a7358e348f84a8ec9d60e3eae921691fcbe35ba
Author: Dominik Stadler <centic@...>
Date: 2017-11-19T19:53:44Z
Handle case where the JaCoCo zip file is available, but the extracted files
are missing, not sure how that happens, but we see it on some CI machines...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815755
13f79535-47bb-0310-9956-ffa450edef68
commit d99e4ea649bcc5c85b03df3b3c41bf4784fed387
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-20T20:46:16Z
upgrade to commons-codec 1.11
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815852
13f79535-47bb-0310-9956-ffa450edef68
commit d4f15fafa9bd6c809af1454474c45b684831b699
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-20T23:35:36Z
[bug-61792] some changes to avoid iterating over chars of Strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815871
13f79535-47bb-0310-9956-ffa450edef68
commit c1ae77c8ce86b2c05ab426ad451fbfc61302538e
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-20T23:58:13Z
[bug-61792] basic test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815873
13f79535-47bb-0310-9956-ffa450edef68
commit 2f755d8d9b696eb8e1caed007c7cd816a8fd9338
Author: Dominik Stadler <centic@...>
Date: 2017-11-21T16:28:07Z
Try if using a local temporary directory avoids the permission errors in
unit tests in the Maven runs:
* Collect JUnit results
* Set java.io.tmpdir in Maven unit test runs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815951
13f79535-47bb-0310-9956-ffa450edef68
commit 90e72ea9fcfaeb074dfe45c83628733e6b47bec0
Author: Dominik Stadler <centic@...>
Date: 2017-11-21T16:29:01Z
Ensure that no old version of commons-codec is lingering around and causes
hard to find build errors locally
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815952
13f79535-47bb-0310-9956-ffa450edef68
commit 5bf0a46aec4738ff5eb2e2602969b8b755a3b5b6
Author: Dominik Stadler <centic@...>
Date: 2017-11-21T17:32:48Z
Try to set java.io.tmpdir for tests to avoid the strange permission errors
that we see in CI-builds
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815963
13f79535-47bb-0310-9956-ffa450edef68
commit 2b02a97d6a8a60d084bcf39e1ebd841a6348658d
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-21T21:11:07Z
remove more uses of Character.toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815988
13f79535-47bb-0310-9956-ffa450edef68
commit 0675acb64abf8bc65a606871e048b54a7beb8910
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-21T21:33:51Z
add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815989
13f79535-47bb-0310-9956-ffa450edef68
commit 268bcdbc2d9a0d002a00813d6a9cd0beab967acb
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-21T22:10:48Z
add forbidden api checks for non-Locale toLowerCase and toUpperCase
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815994
13f79535-47bb-0310-9956-ffa450edef68
commit d695f8ad68beb0dc2425c37f6c35a079832078d5
Author: PJ Fanning <fanningpj@...>
Date: 2017-11-22T01:07:24Z
use codepoint iterator in a few places
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815998
13f79535-47bb-0310-9956-ffa450edef68
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
