https://bz.apache.org/bugzilla/show_bug.cgi?id=63029

Axel Dörfler <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major

--- Comment #3 from Axel Dörfler <[email protected]> ---
Sorry, if I had the time for that, I would have delivered a patch already ;-)

But I've read into the sources a bit more; turns out that only
OPCPackage.close() calls into ZipPackage.closeImpl(), and that is *not* called
in case of PackageAccess.READ. So that part is a wrong assumption of mine.

I should have called OPCPackage.revert() instead of close() -- not the most
intuitive API choice, but my fault in the end.

The only remaining issue is that the file is lost if ZipPackage.closeImpl() is
aborted at the wrong time. It really should, if possible, use an atomic move to
replace the original file instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to