GitHub user Alain-Bearez opened a pull request:
https://github.com/apache/poi/pull/138
Fix some LGTM alerts
Some time ago I started to fix the LGTM alerts, grouping them by their
type. Many groups are still to be handled but these few fixes might be worth to
be pushed to trunk already.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cuali/poi fix-lgtm-alerts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/poi/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit 79241c6788e901e5932ff2db8d183618d0ea3d9d
Author: Alain FAGOT BEAREZ <abearez@...>
Date: 2018-11-01T19:23:39Z
fix potential input resource leaks (LGTM)
commit abe3a3b51e3040f140da00ac664a9b69b21d20eb
Author: Alain FAGOT BEAREZ <abearez@...>
Date: 2018-11-19T23:59:36Z
fix override of synchronized method
commit 1628be8002996f22d31b017250e0dbe9120eda3a
Author: Alain FAGOT BEAREZ <abearez@...>
Date: 2018-11-20T00:21:18Z
fix boxed variable is never null
commit 4fd2019119021f80bd7165fe1602d8a03228ab51
Author: Alain FAGOT BEAREZ <abearez@...>
Date: 2018-11-20T00:29:29Z
fix whitespace contradicts operator precedence
commit f1dfd825f7dd8ffc1f1716d97adfd47f96894647
Author: Alain FAGOT BEAREZ <abearez@...>
Date: 2018-12-25T18:11:53Z
fix potential output resource leaks (LGTM)
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
