I took a brief look at the sheet name errors. Looks like external reference names, and HSSF doesn't throw a specific error when the external reference workbook isn't defined, just returns -1 for the sheet index, which then translates to an empty string for the sheet name, which eventually fails validation. Looks deeper than I want to touch at this point, and not something anyone has complained about, so likely a rare use case for now. I'm OK with leaving it for a later release.
On Fri, Mar 22, 2019 at 7:10 AM Dominik Stadler <[email protected]> wrote: > Hi, > > I quickly reviewed the reported new failures. All the ones with "Formula" > or "HSSFOptimizer" are caused by additional testing that is now done, none > of them points to a newly introduced regression in Apache POI. So we can > add fixes for any of those if we find ways, but none of them should block a > release. > > Dominik. > > On Thu, Mar 21, 2019 at 8:14 AM Dominik Stadler <[email protected]> > wrote: > > > Can you remove the 3.0.2 files from > > https://dist.apache.org/repos/dist/dev/poi/xmlbeans/, they are available > > as official release anyway. > > > > File names are slightly different now, not sure if this is intended or > > will cause issues: xmlbeans-3.0.2-src.tgz > > < > https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src/xmlbeans-3.0.2-src.tgz > > > > vs. xmlbeans-src-3.0.3.tgz > > < > https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src/xmlbeans-src-3.0.3.tgz > >, > > similar for bin: xmlbeans-3.0.2.tgz > > < > https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin/xmlbeans-3.0.2.tgz > > > > vs. xmlbeans-bin-3.0.3.tgz > > < > https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin/xmlbeans-bin-3.0.3.tgz > > > > > > Inside the files I found the following differences compared to 3.0.2: > > > > * In the bin-files, the folder docs/reference is missing, this included > > javadoc in 3.0.2 > > * jar-files in the bin-tgz are now called xmlbeans-3.0.3.jar compared to > > just xmlbeans.jar before. files for javadoc and src jars are new in the > > bin-tgz > > * in the bin-tgz, lib/xmlbean_xpath.jar and xmlpublic.jar are missing. > Not > > sure what they were used for, though > > * in the bin-tgz, the README is not updated, it actually still states > > 2.5.0, so it was not updated in a long time > > * The content of the src-tgz/zip is fairly different, libs are moved > > around, the folder "bin" with scripts is missing, ... most of it will be > > on-purpose, but we should check, I don't know XMLBeans well enough to be > > sure > > * We should exclude file "build.javacheck.xml" in the packaging, it is > > used by CI jobs, but not useful to include > > > > > > Dominik. > > > > On Thu, Mar 21, 2019 at 12:00 AM Greg Woolsey <[email protected]> > > wrote: > > > >> I have pushed xmlbeans 3.0.3 release candidate to: > >> > >> > >> > https://repository.apache.org/content/repositories/staging/org/apache/xmlbeans/xmlbeans/3.0.3/ > >> > >> https://dist.apache.org/repos/dist/dev/poi/xmlbeans/bin > >> https://dist.apache.org/repos/dist/dev/poi/xmlbeans/src > >> > >> If those look good to folks, what do I do to "release" from staging in > the > >> repository? Do I just click the "Release" button in the web interface, > >> perhaps selecting "Public Repositories" if there is a prompt? > >> > >> I assume I then modify site docs like site.xml, modifying 3.0.2 to > 3.0.3, > >> then running forrest and committing. It's my understanding we don't > need > >> to do anything special to release the site changes? > >> > >> Any other steps? I'm thinking I should also commit what I've done in a > >> build instructions file so this thread and the previous one aren't the > >> source for future releases. > >> > >> Maybe also mentioning the AdblockPlus Chrome and Firefox extensions > break > >> nexus uploads unless you exclude the repository domain. That cost me a > >> bit > >> of time. > >> > > >
