I've prepared a 4.1.0 (RC1) and commited it to the dist/dev/poi repo,
however before I bother calling a vote, I wanted to ask about an issue I
had with running
release-prep3
It failed to sign the files until I downgraded to BouncyCastle 1.51 due to
commons-openpgp, which is stuck on BouncyCastle 1.51 or older because it
uses an API method removed in 1.52.
I updated the dsig.bouncycastle* and dist.bouncycastle* properties to 1.51
in build.xml and it worked, but I think that reverts the build dependency
also then, not just the signing? Updating just dsig.bouncycastle*
properties puts both versions in the build/release/compile-lib folder, and
the 1.61 version gets loaded when I run ant.
Maybe it's just jetlag, but I'm unclear on what needs changing to make sure
only the signing step uses the 1.51 libs, and the rest uses the latest
version.
I think the RC artifacts are fine, but let me know if we should straighten
this out first, and possibly do an RC2.
It looks like the build.xml referenced 1.60 for the 4.0.2 release, but the
BC source history shows the method in question disappeared years ago.
Here's the stack I got with 1.61 in the path, for reference. Note the
single-arg constructor doesn't exist in 1.61:
dist-checksum:
[get] Destination already exists (skipping):
\svn\ApachePOI\build\release\compile-lib\bcprov-ext-jdk15on-1.61.jar
[get] Destination already exists (skipping):
\svn\ApachePOI\build\release\compile-lib\bcpg-jdk15on-1.61.jar
[get] Destination already exists (skipping):
\svn\ApachePOI\build\release\compile-lib\commons-openpgp-1.0-SNAPSHOT.jar
BUILD FAILED
\svn\ApachePOI\build.xml:2651: The following error occurred while executing
this line:
\svn\ApachePOI\build\release\build.xml:2410: java.lang.NoSuchMethodError:
org.bouncycastle.openpgp.PGPObjectFactory.<init>(Ljava/io/InputStream;)V
at
org.apache.commons.openpgp.BouncyCastleKeyRing.addSecretKeyRing(BouncyCastleKeyRing.java:86)
at
org.apache.commons.openpgp.BouncyCastleKeyRing.<init>(BouncyCastleKeyRing.java:58)
at
org.apache.commons.openpgp.ant.OpenPgpSignerTask.execute(OpenPgpSignerTask.java:139)
at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at
org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
at
org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38)
at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:441)
at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at
org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
at
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
at org.apache.tools.ant.Main.runBuild(Main.java:857)
at org.apache.tools.ant.Main.startAnt(Main.java:236)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113)
On Thu, Apr 4, 2019 at 11:02 AM Greg Woolsey <greg.wool...@gmail.com> wrote:
> Changed the build.xml URL.
>
> On Thu, Apr 4, 2019 at 10:56 AM Dominik Stadler <dominik.stad...@gmx.at>
> wrote:
>
>> Try using https://nexus.pentaho.org/, seems the repository moved some
>> time
>> ago.
>>
>> I'll add the relevant fetch-target to the build-target "jenkins" so it is
>> executed in CI and we find such issues earlier.
>>
>> Dominik.
>>
>> On Thu, Apr 4, 2019 at 6:49 PM Greg Woolsey <greg.wool...@gmail.com>
>> wrote:
>>
>> > I get "Access Denied" when I try to run release-prep1 when it tries to
>> > retrieve this file:
>> >
>> > Can't get
>> >
>> >
>> http://repo.pentaho.org//content/groups/omni/tigris/svnClientAdapter/svnant-1.3.0/svnClientAdapter-svnant-1.3.0.jar
>> >
>> > Anyone know why?
>> >
>> > Ant output:
>> >
>> > BUILD FAILED
>> > C:\Users\GregWoolsey\svn\ApachePOI\build.xml:868: The following error
>> > occurred while executing this line:
>> > C:\Users\GregWoolsey\svn\ApachePOI\build.xml:625: Can't get
>> >
>> >
>> http://repo.pentaho.org//content/groups/omni/tigris/svnClientAdapter/svnant-1.3.0/svnClientAdapter-svnant-1.3.0.jar
>> >
>> > On Wed, Apr 3, 2019 at 6:28 AM Dominik Stadler <dominik.stad...@gmx.at>
>> > wrote:
>> >
>> > > Sorry for the late reply, I will try to start another run toda, but
>> you
>> > > don't to delay release work because of it.
>> > >
>> > > Dominik
>> > >
>> > > On Tue, Apr 2, 2019, 00:15 Greg Woolsey <greg.wool...@gmail.com>
>> wrote:
>> > >
>> > > > Dominik, is it worth running the regression corpus again, to verify
>> how
>> > > > many of the new errors are cleaned up?
>> > > >
>> > > > On Sat, Mar 30, 2019 at 9:38 PM Greg Woolsey <
>> greg.wool...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Build working again. Latest fix should also remove most of the
>> > > > > differences in the regression run seen last week. I'm happy with
>> the
>> > > > > current state for a 4.1.0 release. Bit of churn today, but they
>> were
>> > > > small
>> > > > > changes and are now sorted.
>> > > > >
>> > > > > On Sat, Mar 30, 2019 at 2:14 PM Kai Grabfelder <
>> > > nos...@kaigrabfelder.de>
>> > > > > wrote:
>> > > > >
>> > > > >> Would it be possible to also include
>> > > > >> https://bz.apache.org/bugzilla/show_bug.cgi?id=61700? I can also
>> > > > provide
>> > > > >> a pull request if that is prefered over the patch.
>> > > > >>
>> > > > >> Best Regards
>> > > > >>
>> > > > >> Kai Grabfelder
>> > > > >> Greg Woolsey schrieb am 30.03.19 um 21:16:
>> > > > >>
>> > > > >> Anyone have anything else they want in before I start the build
>> and
>> > > > release
>> > > > >> process?
>> > > > >>
>> > > > >> I just cleaned up the recent issues that mattered to me around
>> > formula
>> > > > >> evaluation and data formatting. Turns out they were somewhat
>> > related
>> > > in
>> > > > >> code, but unrelated in discovery.
>> > > > >>
>> > > > >>
>> > > > >>
>> > > >
>> > >
>> >
>>
>
