Done. CI for the pull request still fails due to an unrelated issue (Bug 63794 - Synchronization of Github mirror is broken). When commenting out the unrelated test case, build succeeds. I hope that one can be resolved soon so that we can get this into trunk. As an alternative, I could create a patch against SVN trunk.
- DateUtil: Added new methods for LocalDate and LocalDateTime - Cell: added getCellLocalDateTimeValue(), Cell.setCellValue(LocalDateTime) and Cell.setCellValue(LocalDate). I did not add Cell.getCellLocalDateValue() as that would truncate the time information (java.util.Date actually stores date and time, the derived(!) class java.sql.Date then strips support for time - what a mess). I implemented Cell.setCellValue(LocalDate) as a default method in the interface. IMHO that increases maintainability. Now that Java 8 is required, there are multiple places in the code base where that could be used to make POI a little more lightweight. Please review and comment. Axel On 2019/09/28 08:59:56, Axel Howind <mailxze...@gmail.com> wrote: > Ok, I'll create an RFE and add a pull request. > > On 2019/09/27 15:57:08, Nick Burch <apa...@gagravarr.org> wrote: > > On Fri, 27 Sep 2019, Axel Howind wrote: > > > since version 4.0.1, POI requires at least Java 8. I suggest adding > > > support for the new Java Date/Time API introduced with that version of > > > the JDK, i.e. `Cell.getLocalDateValue()` `Cell.getLocalDateTimeValue()` > > > and two matching overloads of `Cell.setCellValue()`. What do you think? > > > If I get positive feedback, I'll probably find the time to submit a > > > patch after mid october. > > > > Seems like a useful update to me! > > > > DateUtil could also potentially use similar methods too > > > > Thanks > > Nick > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
