https://bz.apache.org/bugzilla/show_bug.cgi?id=64241

Andreas Beeker <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Andreas Beeker <[email protected]> ---
Fixed now also the tint/shading issue via r1875522

Tint and shading are based on scRGB opposed to HSL colorspace. [1]

Currently the order of tint/shading/*mod is hard-coded in DrawPaint - this
needs probably be adapted [2] - I haven't checked how to handle HSLF records
then ... I'll open a separate issue for this, when I'll have validated that
really different values will result .. i.e. I assume that office always uses
the same order ...

The conversion logic can be also seen in .Net 4.8 code [3]

Libre office calculates the colors slightly different [4] - they use a gamma
correction of 2.3 (POI uses 2.4 mostly) and the conversion between rgb <->
scRgb <-> hsl is more likely to be rgb <-> crgb <-> hsl. Hence the colors
differs between POI and LO.


[1]
https://social.msdn.microsoft.com/Forums/office/en-US/f6d26f2c-114f-4a0d-8bca-a27442aec4d0/tint-and-shade-elements?forum=oxmlsdk

[2]
https://social.msdn.microsoft.com/Forums/en-US/f7d46b14-6c7d-460b-96c6-5625724afa27/what-order-does-office-apply-shadetinthuemodsatmodlummod-color-modifiers?forum=os_binaryfile

[3]
https://referencesource.microsoft.com/#PresentationCore/Core/CSharp/System/Windows/Media/Color.cs,1048

[4]
https://github.com/LibreOffice/core/blob/master/oox/source/drawingml/color.cxx

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to