Ok, then I am +1 based mostly on comparing the two releases as I don't use XmlBeans outside of POI at all and thus don't know much about using/testing it.
Having it running in Apache POI trunk also indicates that it fullfills it's main use-case successfully! Thanks... Dominik. On Wed, Mar 10, 2021 at 11:11 PM Andreas Beeker <kiwiwi...@apache.org> wrote: > Hi Dominik, > > @compile with JDK14: I haven't done this on purpose, i.e. I should have > used the JDK8, but POI compiles/runs with that Jar and OpenJDK8. > The javac calls in the build.xml refer to "release='8'" except of the > multimodule part, so I think this should be ok. > Although I've provided a multimodule class for the maven plugin, I'm not > sure if this would be picked up when maven runs on the classpath mode. > > @moved pom.xml: I've moved it - when I've implemented the maven plugin - > to have the same structure as a typical maven build artifact, e.g. like > commons-compress. So this is ok. > > Andi. > > On 10.03.21 09:41, Dominik Stadler wrote: > > Hi, > > > > Thanks for preparing, I have two quick questions before I can vote: > > > > there is a new pom.xml file included in the "maven" directory, previously > > it was included in the xmlbeans-4.0.0.jar, where it is missing now. Is > this > > an expected change in deployment? > > > > Previous build was done with OpenJDK 8, this seems to be built with JDK > 14. > > Will this cause issues? > > > > Dominik. > > > > > > > > On Wed, Mar 10, 2021 at 12:07 AM Andreas Beeker <kiwiwi...@apache.org> > > wrote: > > > >> Hi *, > >> > >> I've prepared artifacts for the release of Apache XmlBeans (RC1). > >> > >> The most notable changes in this release are: > >> > >> * Partial method generation and remove inner factory classes - > >> re-generation of the beans necessary > >> * use log4j-2 for logging > >> * Provide Maven plugin > >> > >> https://dist.apache.org/repos/dist/dev/poi/xmlbeans/5.0.0-RC1/ > >> > >> Unfortunatly I haven't automized the XmlBeans release process, so please > >> give it a second look. > >> I had to update my gpg key and de-priotize sha1 handling, so you might > >> need to reimport my key from the KEYS file. > >> Maybe also have a look at the website, so we eventually get the > >> announcement through without an A38 permit. > >> > >> Please vote to release the artifacts. > >> The vote keeps open until 2021-03-13 23:00 UTC. > >> Planned release announcement date is Sunday, 2021-03-14. > >> > >> Here is my +1 > >> > >> Andi > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > >> For additional commands, e-mail: dev-h...@poi.apache.org > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
