pjfanning commented on a change in pull request #290:
URL: https://github.com/apache/poi/pull/290#discussion_r773927305



##########
File path: poi/src/main/java/org/apache/poi/ss/usermodel/Workbook.java
##########
@@ -220,6 +222,32 @@ Licensed to the Apache Software Foundation (ASF) under one 
or more
      */
     Iterator<Sheet> sheetIterator();
 
+    /**
+     * Alias for {@link #sheetIterator()} to allow foreach loops
+     */
+    @Override
+    default Iterator<Sheet> iterator() {
+        return sheetIterator();
+    }
+
+    /**
+     *  Returns a spliterator of the sheets in the workbook
+     *  in sheet order. Includes hidden and very hidden sheets.
+     *
+     * @return a spliterator of the sheets.
+     */
+    default Spliterator<Sheet> sheetSpliterator() {

Review comment:
       maybe, we only need spliterator() - I know we have 2 iterator methods 
but that is some legacy stuff - I don't think new stuff needs to add 2 separate 
methods




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to