Hi Andreas, I'm ok with reverting the test jar changes.
On Saturday 22 January 2022, 22:06:41 GMT+1, Dominik Stadler <dominik.stad...@gmx.at> wrote: Hi, sorry for breaking the build, unfortunately these Java 9+ module stuff is quite a mystery for me as well.We can revert to the previous state if you think your current solution is not final. Would be nice if we can decide to ditch Java 8 at some point so we can simplify the build and then have less "works on Java 8, but breaks on Java 9+" issues. Thanks... Dominik. On Sat, Jan 22, 2022 at 3:37 PM PJ Fanning <fannin...@yahoo.com.invalid> wrote: > Hi, > I've tried to fix the build issues in Java 9+ that happened after > https://github.com/apache/poi/commit/bba249d52207799dc984efd884353aa4783c1c40 > > This change seems worthwhile so I tried to fix the underlying compile > issues but ran into trouble with the test tasks setting module stuff. By > commenting out this module stuff, the test tasks run again (on my laptop). > I may not have fixed all the submodules yet and will have to leave it for > the next few hours. > > > https://github.com/apache/poi/commit/ca9cf3c6f83e06fe2504a01fff4bb7b53f44f577 > > https://github.com/apache/poi/commit/1ee199b1ea8ce524d734aa5e9fa7fbe0c4a52ac0 > > If anyone knows more about Jigsaw modules than me (and I don't much) -- > maybe they can have a look. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
