xzel23 commented on code in PR #321:
URL: https://github.com/apache/poi/pull/321#discussion_r847300532


##########
poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java:
##########
@@ -950,7 +950,7 @@ private String getFormattedNumberString(Cell cell, 
ConditionalFormattingEvaluato
         if (numberFormat == null) {
             return String.valueOf(d);
         }
-        String formatted = numberFormat.format(d);
+        String formatted = numberFormat.format(new 
BigDecimal(String.valueOf(d)));

Review Comment:
   If I had time... Let's just keep it in like this until there is time to look 
into the formatter.
   
   BTW just last week I found some hand crafted number formatting code in an 
arbitrary precision library I once wrote and while I don't remember why I would 
have implemented such a conversion myself I bet it must have been an issue like 
this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to