https://bz.apache.org/bugzilla/show_bug.cgi?id=66087

--- Comment #11 from Patrick Böker <[email protected]> ---
(In reply to PJ Fanning from comment #9)
> In your patch, you use `.toUpperCase().toLowerCase()` - why both?

I looked up what `.equalsIgnoreCase()` is doing
(https://javadoc.scijava.org/Java11/java.base/java/lang/String.html#equalsIgnoreCase(java.lang.String))
and tried to mimic that. I don't know the deeper reason behind it though.

> Also, this will fail our code quality checks - we do not allow toUpperCase
> or toLowerCase without providing a Locale. Have you run a build of this
> change? The build target is called `forbiddenapis`.

Actually I didn't do a full build after the change. I only ran the tests. I
tried it now. As you said, the build does actually error. Thanks for pointing
that out. I'll try to do a full build *before* next time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to