I quickly tried to fix/adjust a few things, maven-xml-version and java9 folders should be fine now, maybe you can roll a RC2 with those to see if we are good now.
Thanks... Dominik. On Sat, Jun 4, 2022 at 9:25 AM Dominik Stadler <[email protected]> wrote: > Hi PJ, > > that already looks better, the "version" folder is now in place. > > but still a few things that I am not sure about: > > * the maven plugin.xml and pom.xml under "maven" do not have a version > set, but rather @VERSION@ > * We seem to duplicate the class to the "org" folder in META-INF, but that > is probably not causing any issues > * log4j-core is not included any more in the "bin" distribution > > I'll see if I manage a quick glance at the build.gradle stuff, but maybe > Andi can take a look as he did this for the Apache POI side as well and > thus seems to know the most about this topic... > > > Thanks... Dominik. > > > On Fri, Jun 3, 2022 at 8:04 PM PJ Fanning <[email protected]> > wrote: > >> Hi Dominik, >> I changed the gradle build and I think the CI build for Java 11 is closer >> to what is needed. The build produces Java 8 compatible classes. >> >> Could you have a look at the jar in >> https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.11/56/ ? >> >> If that one looks ok, I can produce an RC2 based on that build. >> >> >> >> >> On Friday 3 June 2022, 16:46:47 IST, PJ Fanning >> <[email protected]> wrote: >> >> >> >> >> >> Doesn't look right. I wasn't involved in the Gradle changes for XmlBeans >> but the jar doesn't seem right. The licenses/notices are there but have >> moved to META-INF. I think this is ok. But the missing META-INF/versions/9 >> is an issue that blocks the release. Even the jars built with Java 11 are >> missing this. >> >> So -1 from me for the RC1. I will see what can be done to get an RC2 >> together but Gradle is not an area of expertise for me. >> >> >> >> >> >> >> On Friday 3 June 2022, 16:04:46 IST, Dominik Stadler < >> [email protected]> wrote: >> >> >> >> >> >> Hi, >> >> As always, thanks PJ for preparing the release! >> >> I compared release artifacts and the contents of directory META-INF in >> the main jar-file is fairly different between 5.0.3 and 5.1.0, probably due >> to switching to Gradle. >> >> Is this expected? >> >> The "Java 9+" support may break because related files are not located >> under "version/9" directory any more, or? >> >> >> >> >> Also not sure if we need to include LICENSE and NOTICE files in each jar >> for legal reasons, but previously we did and now not any more. >> >> And META-INF/maven is gone, not sure if that is relevant, though. >> >> Dominik. >> >> On Thu, Jun 2, 2022 at 12:55 PM PJ Fanning <[email protected]> >> wrote: >> > Hi everyone, >> > >> > I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC1). >> > One thing to watch out for is in the src artifacts now should be built >> with gradle - instead of ant. >> > >> > The most notable changes in this release are: >> > >> > * create temp files using java.nio.files.Files >> > * Line breaks in base64binary caused a validation error >> > * Improve support for using XMLBeans on Android by not relying on the >> namespace-prefixes feature on the XML SAX parser >> > * Use generics in Collections >> > * GDate can return diferent values on different current timezones >> > * Migrate ant build to gradle >> > * change version code so that the value is automatically generated >> > * Make XmlCursor AutoCloseable >> > * Fix some problems with XMLBeans Extension Interfaces Feature >> > * Inner Class Handler was not supported >> > * When specifying user types in an xsdconfig, types that are not being >> compiled could not be referenced properly >> > * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api >> 2.17.2) >> > >> > A full list of changes is available in the change log: >> > https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699 >> > >> > The artifacts are at: >> > https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/ >> > >> > >> > You can use this maven URL for your mvn/gradle builds: >> > https://repository.apache.org/content/repositories/staging >> > >> > I haven't updated the "provided" dependencies as those have to be >> > activated anyway explicitly. >> > >> > Please vote to release the artifacts. >> > The vote keeps open until 2022-06-09 23:00 UTC. >> > Planned release announcement date is Friday, 2022-06-10. >> > >> > >> > Here is my +1 >> > >> > >> > PJ >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> >> > >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
