XenoAmess commented on code in PR #339:
URL: https://github.com/apache/poi/pull/339#discussion_r922694627


##########
build.gradle:
##########
@@ -141,6 +141,7 @@ subprojects {
     version = '5.2.3-SNAPSHOT'
     ext {
         bouncyCastleVersion = '1.70'
+        commonsLang3Version = '3.12.0'

Review Comment:
   Or you can just copy the functions needed, means isBlank and isNotBlank, 
from commons-lang3, which is an apache v2 licensed repo from apache, so get 
some codes from there seems resonable, as this is alsy an apache v2 licensed 
repo from apache
   



##########
build.gradle:
##########
@@ -141,6 +141,7 @@ subprojects {
     version = '5.2.3-SNAPSHOT'
     ext {
         bouncyCastleVersion = '1.70'
+        commonsLang3Version = '3.12.0'

Review Comment:
   Or you can just copy the functions needed, means isBlank and isNotBlank, 
from commons-lang3, which is an apache v2 licensed repo from apache, so get 
some codes from there seems resonable, as this is also an apache v2 licensed 
repo from apache
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to