Hello,

We're using OneCellAnchor's to insert images into Excel spreadsheets.

I've been able to achieve this using the reflection API to make POI's
internals accessible and writing my own implementation of
`XSSFDrawing.createPicture` but it's not pretty.

I would like to contribute a pull request to add support directly in POI
but I want to check you're happy with how I'm planning to do so:

   - In XSSFDrawing
      - create a new private createAnchor method
      - Replace all existing calls to createTwoCellAnchor with createAnchor
      - Create a new createOneCellAnchor method
      - In createAnchor check if XSSFClientAnchor has one or two cells set,
      call the appropriate createXCellAnchor method
   - In XSSFClientAnchor
      - Add a public setter for size (setSize(extx: Long, exty: Long))
      - Add a public constructor for a single cell, dx, dy, size x and size
      y (XSSFClientAnchor(int dx1, int dy1, int col1, int row1, long extx, long
      exty)

Would you be happy with this approach and are there any gotchas you can
think of that I should look out for?

Cheers,
James Bench

Reply via email to