pjfanning commented on code in PR #443:
URL: https://github.com/apache/poi/pull/443#discussion_r1140653374
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SheetDataWriter.java:
##########
@@ -397,46 +397,51 @@ protected void outputEscapedString(String s) throws
IOException {
return;
}
- for (Iterator<String> iter = CodepointsUtil.iteratorFor(s);
iter.hasNext(); ) {
- String codepoint = iter.next();
+ for (int i = 0; i < s.length(); i++) {
+ final int codepoint = s.codePointAt(i);
+
switch (codepoint) {
- case "<":
+ case 60: // <
Review Comment:
could you test with `'<'`? - this should have similar performance but would
be more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
