tballison commented on PR #477: URL: https://github.com/apache/poi/pull/477#issuecomment-1603237387
I'm not sure the boolean issue is wrong, just different. When I opened a couple of the files, there was nothing in the cells. Will look deeper later. I'm also concerned about changing the behavior. We could go to 5.3.0, or I could have a major refactoring where I modify all the internal `hasEntry` and `getEntry` to `hasEntryCaseInsensitive` and `getEntryCaseInsensitive`. If Intellij is accurate, there are ~230 uses of `getEntry` and ~90 `hasEntry`. I'm willing to make that change, but it will be a large set of changes -- TBF, a bunch are in unit tests. Let me know what you think. The other thing I shuoldn't have done was change the values of `InternalWorkbook#WORKBOOK_DIR_ENTRY_NAMES`. I should have left that as is and mad my own mods on a new field. I'll change that back to what it was. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
