jsoref commented on code in PR #480:
URL: https://github.com/apache/poi/pull/480#discussion_r1240370948
##########
build.gradle:
##########
@@ -405,7 +405,7 @@ subprojects {
//
https://docs.sonarqube.org/display/SONARQUBE52/Analyzing+with+SonarQube+Scanner+for+Gradle
// for documentation of properties.
//
- // Some additional properties are currently set in the Jenkins-DSL,
see jenksin/create_jobs.groovy
+ // Some additional properties are currently set in the Jenkins-DSL,
see jenkins/create_jobs.groovy
Review Comment:
brand
##########
build.xml:
##########
@@ -3223,7 +3223,7 @@ under the License.
<download-line prop="li3" dist="src" pack="tar.gz"/>
<download-line prop="li4" dist="src" pack="zip"/>
-<echo file="download-snipplet.xml"><![CDATA[
+<echo file="download-snippet.xml"><![CDATA[
Review Comment:
dunno if something cares about the filename...
##########
build.gradle:
##########
@@ -367,7 +367,7 @@ subprojects {
// see
https://github.com/java9-modularity/gradle-modules-plugin/issues/97
// opposed to the recommendation there, it doesn't work to
add ... to the dependencies
// testRuntimeOnly
'org.junit.platform:junit-platform-launcher:1.7.1'
- // gradles gradle-worker.jar is still not a JPMS module
and thus runs as unnamed module
+ // gradle's gradle-worker.jar is still not a JPMS module
and thus runs as unnamed module
Review Comment:
brand
##########
poi-ooxml/src/test/java/org/apache/poi/extractor/ooxml/TestExtractorFactory.java:
##########
@@ -64,7 +64,7 @@ class TestExtractorFactory {
@SuppressWarnings("unused")
private static final File xlsxStrict = getFileAndCheck(ssTests,
"SampleSS.strict.xlsx");
private static final File xltx = getFileAndCheck(ssTests, "test.xltx");
- private static final File xlsEmb = getFileAndCheck(ssTests,
"excel_with_embeded.xls");
+ private static final File xlsEmb = getFileAndCheck(ssTests,
"excel_with_embedded.xls");
Review Comment:
I've tried to rename files that are referenced like this one.
##########
test-data/slideshow/bug57820-initTableNullReferenceException.ppt:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
test-data/slideshow/ppt_with_embedded.ppt:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
poi-ooxml/src/test/java/org/apache/poi/extractor/ooxml/TestExtractorFactory.java:
##########
@@ -73,8 +73,8 @@ class TestExtractorFactory {
private static final File doc95 = getFileAndCheck(wpTests, "Word95.doc");
private static final File docx = getFileAndCheck(wpTests,
"SampleDoc.docx");
private static final File dotx = getFileAndCheck(wpTests, "test.dotx");
- private static final File docEmb = getFileAndCheck(wpTests,
"word_with_embeded.doc");
- private static final File docEmbOOXML = getFileAndCheck(wpTests,
"word_with_embeded_ooxml.doc");
+ private static final File docEmb = getFileAndCheck(wpTests,
"word_with_embedded.doc");
+ private static final File docEmbOOXML = getFileAndCheck(wpTests,
"word_with_embedded_ooxml.doc");
Review Comment:
these are renamed
##########
poi-scratchpad/src/main/java/org/apache/poi/hwpf/model/SingletonTextPiece.java:
##########
@@ -20,12 +20,12 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
import org.apache.poi.util.StringUtil;
@Internal
-public class SinglentonTextPiece extends TextPiece {
- public SinglentonTextPiece(SinglentonTextPiece other) {
+public class SingletonTextPiece extends TextPiece {
+ public SingletonTextPiece(SingletonTextPiece other) {
Review Comment:
this class and its file are renamed
##########
poi-scratchpad/src/main/java/org/apache/poi/hwmf/record/HwmfFont.java:
##########
@@ -534,7 +534,7 @@ public Map<String, Supplier<?>> getGenericProperties() {
final Map<String,Supplier<?>> m = new LinkedHashMap<>();
m.put("height", this::getHeight);
m.put("width", this::getWidth);
- m.put("escapment", this::getEscapement);
+ m.put("escapement", this::getEscapement);
Review Comment:
?????
##########
poi-scratchpad/src/main/resources/org/apache/poi/hdgf/chunks_parse_cmds.tbl:
##########
@@ -484,7 +484,7 @@ start 148
0 31 AllCaps
1 31 InitCaps
0 32 Subscript
-1 32 Superscipt
+1 32 Superscript
Review Comment:
?
##########
test-data/diagram/visio_with_embedded.vsd:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
poi-ooxml/src/main/java/org/apache/poi/xslf/util/PPTX2PNG.java:
##########
@@ -358,7 +358,7 @@ private OutputFormat getOutput() {
try {
return new SVGFormat(textAsShapes);
} catch (Exception | NoClassDefFoundError e) {
- LOG.atError().withThrowable(e).log("Batik is not not added
to/working on the module-path. Use classpath mode instead of JPMS. Fallback to
PNG.");
+ LOG.atError().withThrowable(e).log("Batik is not added
to/working on the module-path. Use classpath mode instead of JPMS. Fallback to
PNG.");
Review Comment:
doubled words have been historically flagged by spell checking tools...
doubled negatives are problematic...
##########
test-data/openxml4j/TestPackageCorePropertiesGetters.docx:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java:
##########
@@ -405,7 +405,7 @@ private XSSFGraphicFrame
createGraphicFrame(XSSFClientAnchor anchor) {
XSSFGraphicFrame graphicFrame = new XSSFGraphicFrame(this,
ctGraphicFrame);
graphicFrame.setAnchor(anchor);
graphicFrame.setId(frameId);
- graphicFrame.setName("Diagramm" + frameId);
+ graphicFrame.setName("Diagram" + frameId);
Review Comment:
is this an api break?
##########
poi/src/main/java/org/apache/poi/hssf/record/TopMarginRecord.java:
##########
@@ -79,6 +79,6 @@ public HSSFRecordTypes getGenericRecordType() {
@Override
public Map<String, Supplier<?>> getGenericProperties() {
- return GenericRecordUtil.getGenericProperties("magin",
this::getMargin);
+ return GenericRecordUtil.getGenericProperties("margin",
this::getMargin);
}
}
Review Comment:
I try not to fix missing newline at end of file warnings in PRs like this,
although I prefer for them not to be missing.
##########
test-data/openxml4j/TestPackageCorePropertiesSetters.docx:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
test-data/document/word_with_embedded_ooxml.doc:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
poi/src/main/java/org/apache/poi/util/LocaleID.java:
##########
@@ -374,7 +374,7 @@ public enum LocaleID {
MN_MONG_MN(0x0C50, "mn_mong_mn", "mn-Mong-MN", "Mongolian (Traditional
Mongolian, Mongolia)", 0, -1),
DZ_BT(0x0C51, "dz_bt", "dz-BT", "Dzongkha (Bhutan)", 0, SUNDAY),
TMZ_MA(0x0C5F, "tmz_ma", "tmz-MA", "tmz (Morocco)", 32759, -1),
- QUZ_PE(0x0C6b, "quz_pe", "quz-PE", "Quechua (Peru)", 1252, -1),
+ QUZ_PE(0x0C6B, "quz_pe", "quz-PE", "Quechua (Peru)", 1252, -1),
Review Comment:
This isn't a spelling fix, it's left beneath all the spelling fixes. All but
these 5 entries use uppercase hex...
##########
poi/src/main/java/org/apache/poi/sl/draw/geom/ArcToCommand.java:
##########
@@ -137,7 +137,7 @@ public static double convertOoxml2AwtAngle(double ooAngle,
double width, double
// normalize angle, in case it's < -360 or > 360 degrees
double awtAngle2 = awtAngle%360.;
double awtAngle3 = awtAngle-awtAngle2;
- // because of tangens nature, the values left [90°-270°] and right
[270°-90°] of the axis are mirrored/the same
+ // because of tangent's nature, the values left [90°-270°] and right
[270°-90°] of the axis are mirrored/the same
Review Comment:
probably?
##########
poi/src/main/java/org/apache/poi/ss/util/SheetBuilder.java:
##########
@@ -117,7 +117,7 @@ public Sheet build() {
* Sets the cell value using object type information.
*
* @param cell cell to change
- * @param value value to set
+ * @param value to set
Review Comment:
actually, i'm going to drop this. I have a partial rule to skip this, but
apparently i wasn't careful enough...
##########
poi/src/test/java/org/apache/poi/hssf/extractor/TestExcelExtractor.java:
##########
@@ -240,17 +240,17 @@ void testFormatting() throws Exception {
}
/**
- * Embeded in a non-excel file
+ * Embedded in a non-excel file
*/
@Test
- void testWithEmbeded() throws Exception {
+ void testWithEmbedded() throws Exception {
POIFSFileSystem fs = null;
HSSFWorkbook wbA = null, wbB = null;
ExcelExtractor exA = null, exB = null;
try {
- fs = new
POIFSFileSystem(POIDataSamples.getDocumentInstance().getFile("word_with_embeded.doc"));
+ fs = new
POIFSFileSystem(POIDataSamples.getDocumentInstance().getFile("word_with_embedded.doc"));
Review Comment:
this should be renamed below
##########
poi/src/test/java/org/apache/poi/hssf/extractor/TestExcelExtractor.java:
##########
@@ -285,7 +285,7 @@ void testWithEmbeddedInOwn() throws Exception {
ExcelExtractor exA = null, exB = null, ex = null;
try {
- fs = new
POIFSFileSystem(ssSamples.getFile("excel_with_embeded.xls"));
+ fs = new
POIFSFileSystem(ssSamples.getFile("excel_with_embedded.xls"));
Review Comment:
this should be renamed below
##########
poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFShape.java:
##########
@@ -69,7 +69,7 @@ public abstract class HSLFShape implements
Shape<HSLFShape,HSLFTextParagraph> {
private static final Logger LOG = LogManager.getLogger(HSLFShape.class);
/**
- * Either EscherSpContainer or EscheSpgrContainer record
+ * Either EscherSpContainer or EscherSpgrContainer record
Review Comment:
hopefully?
##########
poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/TestPackageCoreProperties.java:
##########
@@ -64,9 +64,9 @@ void testGetProperties() throws Exception {
*/
@Test
void testSetProperties() throws Exception {
- String inputPath =
getSampleFileName("TestPackageCoreProperiesSetters.docx");
+ String inputPath =
getSampleFileName("TestPackageCorePropertiesSetters.docx");
Review Comment:
this file is renamed...
##########
test-data/spreadsheet/excel_with_embedded.xls:
##########
Review Comment:
see above for comment about trying to rename references and files...
##########
poi/src/test/java/org/apache/poi/hssf/extractor/TestExcelExtractor.java:
##########
@@ -347,7 +347,7 @@ void testPassword() throws IOException {
@Test
void testNullPointerException() throws IOException {
- try (ExcelExtractor extractor =
createExtractor("ar.org.apsme.www_Form%20Inscripcion%20Curso%20NO%20Socios.xls"))
{
+ try (ExcelExtractor extractor =
createExtractor("ar.org.apsme.www_Form%20Inscripción%20Curso%20NO%20Socios.xls"))
{
Review Comment:
Err, this wasn't the correction I expected to get. I was expecting to leave
`Inscription`...
I'm curious what this is doing...
##########
poi/src/test/java/org/apache/poi/hssf/record/TestFontRecord.java:
##########
@@ -74,7 +74,7 @@ void testStore() {
// .fontheight = c8
// .attributes = 0
// .italic = false
-// .strikout = false
+// .strikeout = false
Review Comment:
?
##########
poi/src/test/java/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java:
##########
@@ -44,7 +44,7 @@ class TestWorkdayFunction {
private static final String FIRST_HOLIDAY = "2008/11/26";
private static final String SECOND_HOLIDAY = "2008/12/04";
private static final String THIRD_HOLIDAY = "2009/01/21";
- private static final String RETROATIVE_HOLIDAY = "2008/09/29";
+ private static final String RETROACTIVE_HOLIDAY = "2008/09/29";
Review Comment:
I could fix up the indentation...
##########
poi-scratchpad/src/main/java/org/apache/poi/hemf/record/emf/HemfText.java:
##########
@@ -110,7 +110,7 @@ public long init(LittleEndianInputStream leis, long
recordSize, long recordId) t
// A WMF PointL object that specifies the coordinates of the
reference point used to position the string.
// The reference point is defined by the last EMR_SETTEXTALIGN
record.
- // If no such record has been set, the defaulint alignment is
TA_LEFT,TA_TOP.
+ // If no such record has been set, the default alignment is
TA_LEFT,TA_TOP.
Review Comment:
`defaulting` was closer but made less sense...
##########
poi-ooxml/src/test/java/org/apache/poi/ooxml/TestDetectAsOOXML.java:
##########
@@ -36,7 +36,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
more
import org.junit.jupiter.params.provider.CsvSource;
/**
- * Class to test that HXF correctly detects OOXML
+ * Class to test that FileMagic correctly detects OOXML
Review Comment:
??
##########
poi/src/test/java/org/apache/poi/poifs/dev/TestPOIFSDump.java:
##########
@@ -170,7 +170,7 @@ public void checkPermission(Permission perm) {
@SuppressForbidden("tests java.security features deprecated in java 17 -
no other option though")
void testMainNoArgs() {
Assumptions.assumeFalse(POITestCase.getJDKVersion() >= 18,
- "SecurityManager does not work any more since JDK 18");
+ "SecurityManager does not work since JDK 18");
Review Comment:
in principle, this should be `anymore`, but in practice, it's superfluous,
so I removed it.
##########
poi/src/test/java/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java:
##########
@@ -130,7 +130,7 @@ void testAlwaysClose() throws IOException {
* multiple of 512 bytes)
*
* As yet, this problem remains. One school of thought is
- * not not issue an EOF when we discover the last block
+ * not to issue an EOF when we discover the last block
Review Comment:
or `to not`, but I think this is the right change...
##########
poi/src/test/java/org/apache/poi/hssf/usermodel/TestHSSFSheet.java:
##########
@@ -359,7 +359,7 @@ void getDrawings() throws IOException {
*/
@Test
void cloneWithProtect() throws IOException {
- String passwordA = "secrect";
+ String passwordA = "secret";
int expectedHashA = -6810;
Review Comment:
this hash probably needs to be updated...
##########
poi-ooxml/src/test/java/org/apache/poi/xwpf/extractor/TestXWPFWordExtractor.java:
##########
@@ -48,7 +48,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
more
import javax.xml.namespace.QName;
/**
- * Tests for HXFWordExtractor
+ * Tests for XWPFWordExtractor
*/
class TestXWPFWordExtractor {
Review Comment:
?
##########
poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestRow.java:
##########
@@ -283,7 +283,7 @@ void testGetCellPolicy() throws IOException {
// Now change the cell policy on the workbook, check
- // that that is now used if no policy given
+ // that it is now used if no policy given
Review Comment:
atypical correction
##########
poi-scratchpad/src/main/java/org/apache/poi/hwmf/record/HwmfPalette.java:
##########
@@ -167,7 +167,7 @@ int getPaletteStart() {
public Map<String, Supplier<?>> getGenericProperties() {
return GenericRecordUtil.getGenericProperties(
"paletteStart", this::getPaletteStart,
- "pallete", this::getPaletteCopy
+ "palette", this::getPaletteCopy
Review Comment:
????
##########
poi-scratchpad/src/test/java/org/apache/poi/hwpf/extractor/TestWordExtractor.java:
##########
@@ -137,8 +137,8 @@ void testExtractFromTextPieces() throws IOException {
* Test that we can get data from two different embedded word documents
*/
@Test
- void testExtractFromEmbeded() throws IOException {
- InputStream is =
POIDataSamples.getSpreadSheetInstance().openResourceAsStream("excel_with_embeded.xls");
+ void testExtractFromEmbedded() throws IOException {
+ InputStream is =
POIDataSamples.getSpreadSheetInstance().openResourceAsStream("excel_with_embedded.xls");
Review Comment:
renamed
##########
poi-scratchpad/src/test/java/org/apache/poi/hwpf/usermodel/TestPictures.java:
##########
@@ -144,10 +144,10 @@ void testFastSaved(String file) throws IOException {
* Check that we can properly read one of these
*/
@Test
- void testEmbededDocumentIcon() {
+ void testEmbeddedDocumentIcon() {
// This file has two embedded excel files, an embedded powerpoint
// file and an embedded word file, in that order
- HWPFDocument doc = openSampleFile("word_with_embeded.doc");
+ HWPFDocument doc = openSampleFile("word_with_embedded.doc");
Review Comment:
renamed
##########
poi-scratchpad/src/test/java/org/apache/poi/hwpf/usermodel/TestBugs.java:
##########
@@ -592,7 +592,7 @@ void testBug51944() throws Exception {
@CsvSource({
// Bug 51834 - Opening and Writing .doc file results in corrupt
document
// we don't have Java test for this file - it should be checked using
- // Microsoft BFF Validator. But check read-write-read anyway. -- sergey
+ // Microsoft Office Binary File Format Validator. But check
read-write-read anyway. -- sergey
Review Comment:
searching for `Microsoft BFF Validator` doesn't work particularly well...
##########
poi-scratchpad/src/main/resources/org/apache/poi/hdgf/chunks_parse_cmds.tbl:
##########
@@ -332,7 +332,7 @@ start 133
4 50 LineEndEnd
5 50 LineEndBegin
6 50 EndSize
-7 50 SqueareCap
+7 50 SquareCap
Review Comment:
?
##########
poi/src/main/java/org/apache/poi/hssf/record/aggregates/ConditionalFormattingTable.java:
##########
@@ -27,7 +27,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
more
/**
* Holds all the conditional formatting for a workbook sheet.<p>
*
- * See OOO exelfileformat.pdf sec 4.12 'Conditional Formatting Table'
+ * See OOO excelfileformat.pdf sec 4.12 'Conditional Formatting Table'
Review Comment:
https://www.openoffice.org/sc/excelfileformat.pdf
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFShapeTypes.java:
##########
@@ -23,7 +23,7 @@ public interface HSSFShapeTypes {
public static final int RoundRectangle = 2;
public static final int Ellipse = 3;
public static final int Diamond = 4;
- public static final int IsocelesTriangle = 5;
+ public static final int IsoscelesTriangle = 5;
Review Comment:
is this a public api that can't be changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
