pjfanning commented on code in PR #489:
URL: https://github.com/apache/poi/pull/489#discussion_r1272692808


##########
poi/src/test/java/org/apache/poi/ss/format/TestCellFormat.java:
##########
@@ -1046,4 +1046,11 @@ void testNamedColors() {
                 .map(CellFormatPart.NAMED_COLORS::get)
                 .forEach(Assertions::assertNotNull);
     }
+
+    @Test
+    void testElapsedSecondsRound() {

Review Comment:
   * this looks like a better way to test this
   * the tests where we read xlsx files and match their results can be easily 
broken and the PRs are hard to review because you can't see the diff in the 
xlsx files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to