pjfanning commented on code in PR #503:
URL: https://github.com/apache/poi/pull/503#discussion_r1297012035


##########
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java:
##########
@@ -423,6 +423,8 @@ public String getText() {
 
     public void setText(String text) {
         XWPFParagraph par = paragraphs.isEmpty() ? addParagraph() : 
paragraphs.get(0);
+        par.getRuns().clear();
+        par.getIRuns().clear();

Review Comment:
   Could you add a new `appendText` method that works the old way? Add javadoc 
to that method saying `@since POI 5.2.4` and javadoc to this method describing 
the change in behaviour in POI 5.2.4. 
   
   Could you add a unit test for the appendText method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to