Hi, +1 from me, thanks P.J.!
Large-scale regression testing looks good, only very very few regressions for more than 3mio documents ( ~0.02% ), most are caused by slightly stricter handling (more than 1000 compressed files, more than 300 nested children), a few remaining cases which we can take a look after release. Results are at http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html and http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html Difference between source-packages from 5.2.3 and 5.2.4 looks good. Building from sources works locally. Upgrading projects to 5.2.4RC1 from the staging Maven repository did work fine, all tests passing. I added a note in the changelog about the removed binary packages, but if possible we should also add a bit more description about this in the announcement email. I think it may disrupt how some people integrate poi and thus may be worth to note in the release notes/announcement as well. I.e. "either build it yourself or download the binaries from Maven Central" Regards... Dominik. On Fri, Sep 22, 2023 at 9:26 PM Tim Allison <talli...@apache.org> wrote: > +1 > > Reports are here: There's surprisingly little difference: > https://corpora.tika.apache.org/base/reports/poi-reports.tgz > > I only had time to glance briefly. > > Thank you PJ and team! > > On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning <fannin...@yahoo.com.invalid> > wrote: > > > Thanks Alex. The pdfbox issue is tracked at > > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a link > > to what is blocking our upgrade. > > > > In terms of the version names of the jars - the ASF has a rule that you > > must release what has been voted on. That means I can't create 5.2.4-RC1 > > jars - get those voted on and then go off and rebuild 5.2.4 jars without > > having those voted on. The jars are not in Maven Central yet, they are > in a > > staging area. Anyone who tests the staging jars will need to consider > > cleaning out their local jar caches (e.g. their Maven local cache) after > > they test the staging jars. Only a small number of POI reviewers will use > > the staging jars. > > > > > > > > > > > > > > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind <a...@dua3.com> > > wrote: > > > > > > > > > > > > +1 for the release. > > > > I just built and tested one of my own projects with the RC and everything > > seems to work just fine. > > > > Two notes: > > - I think release candidates should be published with an "rc“ in the > > version string, something like "5.3.4-rc1“ because otherwise when a > second > > release candidate/the final release becomes available, Maven might stick > > with the old rc build in the local .m2. > > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the > > next major release (3.0.0), but I think switching to pdfbox 3 should be > > more thoroughly tested and would rather be something for POI 5.3 > > > > > Am 21.09.2023 um 23:58 schrieb PJ Fanning <fannin...@apache.org>: > > > > > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > > For additional commands, e-mail: dev-h...@poi.apache.org > > > > >
