pjfanning commented on PR #617: URL: https://github.com/apache/poi/pull/617#issuecomment-2044964656
I think the reason the test might have appeared to work is because the test in the PR has a catch block that justs prints the stack trace but then swallows the exception. We cannot accept tests that swallow exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
