ebourg commented on PR #731: URL: https://github.com/apache/poi/pull/731#issuecomment-2504171701
I've pushed a couple of changes to the [PR branch](https://github.com/ebourg/poi/commits/root-property-size/): * `POIFSMiniStore` now reuses `BATBlock.getOccupiedSize()` to compute the size of the root property. Thus the block array is accessed directly to compute the size instead of going through `BATBlock.getValueAt()` which does a boundary check on each read. (https://github.com/ebourg/poi/commit/dda38f0322d465fd3a2ebbc4dbc45ebd82a16aa9) * `BATBlock.getOccupiedSize()` has been slightly optimized, the `usedSectors` variable was redundant with the loop variable and was removed, that's one less integer allocation per mini FAT sector. (https://github.com/ebourg/poi/commit/a54dcaf5e0877f4eb4206698d9c1f5da60ba0377) I don't know if that's enough for the integration tests to pass, but it can't hurt. If the integration tests still fail then the remaining difference with the previous code is either the double loop over the mini FAT sectors, one forward to write them, and one backward to compute the size, or the different size computed which is always larger or equal than previously and may lead to different memory allocations down the road. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
