https://bz.apache.org/bugzilla/show_bug.cgi?id=65772

--- Comment #5 from Andreas Capellmann <a.capellm...@diskover.de> ---
Thank you for your quick response. I was looking at the most recent version of
the code, i.e. Commit d034f95, but I mixed up the last line number. Well, as
you say: Let's not talk about line numbers.

In the class level Javadoc there is written "Files are collected into one
directory and by default are deleted on exit from the VM." The second part is
not true anymore since your last change. Now they are kept by default! This is
because the "deleteOnExit" flag is only set, if the system property
poi.delete.tmp.files.on.exit is defined. In a default environment it is not set
and so by default the temp files are not deleted but kept.

Also in the class level Javadoc it says "Files can be kept by defining the
system property {@link #DELETE_FILES_ON_EXIT}." This is also an old text and
now wrong. If you set this system property, files are not kept, but deleted.

At last the inline comment in method createTempFile, which says "Set the delete
on exit flag, but only when explicitly disabled". This is kind of misleading.
What the code does is "Set the delete on exit flag, but only if enabled by
defining the system property {@link #DELETE_FILES_ON_EXIT}."

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to