krrg commented on code in PR #775:
URL: https://github.com/apache/poi/pull/775#discussion_r2004141032
##########
poi-ooxml/src/test/java/org/apache/poi/openxml4j/opc/compliance/TestOPCComplianceCoreProperties.java:
##########
@@ -295,4 +305,50 @@ void testNoCoreProperties_saveInPlace() throws Exception {
}
assertTrue(tmp.delete());
}
+
+ /**
+ * Test M4.2 rule not enforced when appropriate OPCComplianceFlag is set.
+ */
+ @Test
+ void testDisableEnforceCompatibilityMarkup() throws IOException {
+ testComplianceFlagOverridePreventsException(
+ "DoNotUseCompatibilityMarkupFAIL.docx",
Review Comment:
These files already exist and are already being used in the neighboring
tests. The existing tests in this file check that we _do_ enforce compliance.
My additional tests confirm that when a specific compliance setting (or
settings) are turned off, the file then parses without error.
I'm using the same `OpenXML4JTestDataSamples.openSampleStream` method the
other tests use, which I believe handles the actual prefixing, etc.
I ran all of the tests with gradle test, and everything passed on my machine
including all the `poi-integration` tests, so I think we're okay? Happy to
adjust anything if I missed something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
