JaroslavTulach commented on code in PR #806:
URL: https://github.com/apache/poi/pull/806#discussion_r2083226065
##########
poi/src/main/java/org/apache/poi/hssf/util/HSSFColor.java:
##########
@@ -324,11 +348,22 @@ public short getIndex2() {
*/
public String getHexString() {
- return (Integer.toHexString(color.getRed()*0x101) + ":" +
- Integer.toHexString(color.getGreen()*0x101) + ":" +
-
Integer.toHexString(color.getBlue()*0x101)).toUpperCase(Locale.ROOT);
+ return (Integer.toHexString(getRed()*0x101) + ":" +
+ Integer.toHexString(getGreen()*0x101) + ":" +
+ Integer.toHexString(getBlue()*0x101)).toUpperCase(Locale.ROOT);
}
+ final short getBlue() {
Review Comment:
- I didn't want to change the API - unless necessary
- there are no usages of these methods outside of this class thus I am
making them private in 449dba6
- the `color` field wasn't publicly accessible either (luckily)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org
