https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

            Bug ID: 69697
           Summary: Error in public HSLFPictureData getPictureData() of
                    class HSLFPictureShape
           Product: POI
           Version: 5.4.1-FINAL
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: critical
          Priority: P2
         Component: HSLF
          Assignee: dev@poi.apache.org
          Reporter: parvathyskumar...@gmail.com
  Target Milestone: ---

Created attachment 40041
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=40041&action=edit
java file that can be used for testing

In the function getPictureData() of class HSLFPictureShape, these lines of code
                // Reference equals is safe because these BSE belong to the
same slideshow
                if (pd.bse == bse) {
                    return pd;
                }
            }
will not work since Reference equals wont be correct here. Instead the old way
of comparing offsets should be used here.

                if (pd.getOffset() ==  bse.getOffset()){
                    return pd;
                }

Attaching a sample .java file with a .ppt file whose picture wont be extracted
due to the error in this comparison.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Reply via email to