pjfanning commented on PR #888: URL: https://github.com/apache/poi/pull/888#issuecomment-3221797027
The existing code is very complicated. The new changes make it even more complicated. It does appear to fix 2 asserts in the tests so that is good and doesn't appear to break anything. I'm still somewhat reluctant to merge because the new code is so hard to read. Maybe someone else who reviews it will find it easier to decipher. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
