pjfanning commented on code in PR #968:
URL: https://github.com/apache/poi/pull/968#discussion_r2612431615
##########
poi-ooxml/src/test/java/org/apache/poi/xslf/usermodel/TestXSLFSlideShow.java:
##########
@@ -16,10 +16,6 @@ Licensed to the Apache Software Foundation (ASF) under one
or more
==================================================================== */
package org.apache.poi.xslf.usermodel;
-import static org.junit.jupiter.api.Assertions.assertEquals;
Review Comment:
keep these instead of using wildcards
##########
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XMLSlideShow.java:
##########
@@ -748,4 +748,48 @@ String importBlip(String blipId, POIXMLDocumentPart
parent, POIXMLDocumentPart t
RelationPart rp = target.addRelation(null, XSLFRelation.IMAGES,
pictureData);
return rp.getRelationship().getId();
}
+
+ /**
+ * Returns the number that shall be displayed on the first slide of the
presentation.
+ * Subsequent slides will be numbered sequentially from this number.
+ * The default value is 1 if the property is not set in the presentation
file.
+ *
+ * @return The starting number for the first slide (default is 1).
Review Comment:
to all new public methods
##########
poi-ooxml/src/main/java/org/apache/poi/xslf/usermodel/XMLSlideShow.java:
##########
@@ -748,4 +748,48 @@ String importBlip(String blipId, POIXMLDocumentPart
parent, POIXMLDocumentPart t
RelationPart rp = target.addRelation(null, XSLFRelation.IMAGES,
pictureData);
return rp.getRelationship().getId();
}
+
+ /**
+ * Returns the number that shall be displayed on the first slide of the
presentation.
+ * Subsequent slides will be numbered sequentially from this number.
+ * The default value is 1 if the property is not set in the presentation
file.
+ *
+ * @return The starting number for the first slide (default is 1).
Review Comment:
can you add `@since 6.0.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
