Simulant87 commented on PR #967: URL: https://github.com/apache/poi/pull/967#issuecomment-3798918554
Actually this creates a new inconsistency. When the creation of a sheet with a too long name is successful, because it silently truncates the name, I would not expect an Exception to be thrown later on during the access with the same too long name. When throwing an exception on the access, it should already throw an exception during the creation for the too long name. Which would break backwards compatibility with the current implementation. Instead you could also truncate the given too long name the same way as during the createSheet, which returns the previous created sheet, and log a warning that the name is actually to long. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
