jogakdal opened a new pull request, #1006: URL: https://github.com/apache/poi/pull/1006
This PR addresses [Bug 69935](https://bz.apache.org/bugzilla/show_bug.cgi?id=69935), where `ClientAnchor` exposes `short`-returning getters for the column indices (`getCol1()`, `getCol2()`) but only `int`-based setters (`setCol1(int)`, `setCol2(int)`). This mismatch makes it difficult to use Kotlin property syntax, which expects matching getter/setter types for a property. ### What is changed - Add default short-based setters on `ClientAnchor`: - `default void setCol1(short col1)` delegating to `setCol1(int)`. - `default void setCol2(short col2)` delegating to `setCol2(int)`. This keeps the existing `int`-based setters intact and binary compatible, while exposing a `short`-typed getter/setter pair that works better with Kotlin properties. - Add `TestClientAnchorShortSetter` to cover: - The new short-based setters delegate correctly to the existing int-based setters. - The existing int-based setters still behave as before. ### Notes - The `@since` tag on the new methods is left as `TBD` and can be adjusted by the committer to the appropriate release version. ### Testing Locally ran: ```bash ./gradlew :poi:test --tests 'org.apache.poi.ss.usermodel.TestClientAnchorShortSetter' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
