pjfanning commented on code in PR #1042:
URL: https://github.com/apache/poi/pull/1042#discussion_r3047629543
##########
poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBUtils.java:
##########
@@ -38,7 +37,7 @@ public class XSSFBUtils {
* @return number of bytes read
* @throws XSSFBParseException if there was an exception during reading
*/
- static int readXLNullableWideString(byte[] data, int offset, StringBuilder
sb) throws XSSFBParseException {
+ public static int readXLNullableWideString(byte[] data, int offset,
StringBuilder sb) throws XSSFBParseException {
Review Comment:
I'm ok with it being public if Tika uses it. Maybe we could document in the
code that that is the reason for it being public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
