kali834x opened a new pull request, #1149: URL: https://github.com/apache/poi/pull/1149
This pull request fixes an equals()/hashCode() contract violation in XSSFColor. equals() compares the logical color properties (ARGB, theme, index, tint, and auto), while hashCode() was based on the underlying CTColor XML string representation. As a result, two logically equal XSSFColor instances could produce different hash codes when created from different XML representations, causing incorrect behavior in hash-based collections and caches. The fix replaces the XML-based hash code calculation with a field-based implementation consistent with the properties used by equals(). A unit test was added to verify that logically equivalent XSSFColor instances created from different XML contexts remain equal and produce identical hash codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
