pjfanning commented on PR #1185: URL: https://github.com/apache/poi/pull/1185#issuecomment-4961766545
@jaragunde I wouldn't favour changing the existing method to return -1 when it never did before. Breaks backward compatibility. Introduce a new method or overload this method but include a new param, maybe a boolean, to control whether -1 or an exception is thrown in the not set case. To be honest, it's not nice but compatibility guarantees matter. My preferred solution would be to add an isSet method that returns a boolean if tcW is set and to update the getWidth javadoc to mention that that is how you get work out the is not set case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
