pjfanning opened a new pull request, #1229: URL: https://github.com/apache/poi/pull/1229
Small cleanup spotted during a review of the XML-mapping export path. `XSSFExportToXml` still declares a private `SecurityFeature` functional interface and a `trySet(String, SecurityFeature)` helper. Both are unreferenced — they date from when this class hardened the `SchemaFactory` itself. That logic now lives in `XMLHelper.getSchemaFactory()` (which disables `ACCESS_EXTERNAL_DTD`/`ACCESS_EXTERNAL_SCHEMA`/`ACCESS_EXTERNAL_STYLESHEET` and enables secure processing), and `XSSFExportToXml` already obtains its factory from there. Removing the dead members. No behaviour change; `TestXSSFExportToXML` and `TestXSSFImportFromXML` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
