The GitHub Actions job "Java CI with Gradle" on 
poi.git/fix/irr-bracketed-fallback has failed.
Run started by GitHub user falhenaki (triggered by falhenaki).

Head commit for run:
6b9ecadb03daee1c47573396faff73c22588aa3f / falhenaki 
<[email protected]>
Bug 64137 follow-up: address review comments on the bracketed fallback

- comment that the coarse bracket-grid tail is intentional (only paired
  roots inside one gap can be missed, never a single root)
- comment on the result > -1 guard in irr() explaining when the
  fallback runs and why a converged rate above -100% is returned as-is
- harden the rtsafe loop against NPV overflow in the sliver next to -1:
  a non-finite f or df now forces a bisection step instead of feeding
  Newton inf/inf, and a NaN NPV no longer moves a bracket endpoint
  (its sign is unknown; moving one could break the bracket invariant).
  For any iterate where f and df are finite, behaviour is unchanged.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01JNGX5YKXHUCZJVAFBEzntj

Report URL: https://github.com/apache/poi/actions/runs/31920913029

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to